Skip to content

Removed dead batch code#210

Merged
GlassOfWhiskey merged 2 commits intomasterfrom
drop-dead-code
Mar 5, 2026
Merged

Removed dead batch code#210
GlassOfWhiskey merged 2 commits intomasterfrom
drop-dead-code

Conversation

@marcoSanti
Copy link
Copy Markdown
Member

This pull request drops dead code present in the CAPIO server component related to a legacy optimization. In particular it drops the logic used to handle batch requests between server instances, which were used previously as streaming was not as stable as it is now.

This drop of dead code is possible, as it was now impossible to trigger the necessary conditions at runtime to enter the removed routines.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 62.43%. Comparing base (c2e5186) to head (6ee9dc1).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
capio/server/include/handlers/close.hpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #210      +/-   ##
==========================================
+ Coverage   59.34%   62.43%   +3.09%     
==========================================
  Files          76       76              
  Lines        3495     3322     -173     
  Branches     2189     2048     -141     
==========================================
  Hits         2074     2074              
+ Misses       1124      436     -688     
- Partials      297      812     +515     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@GlassOfWhiskey GlassOfWhiskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why READ and STAT have the same number?

Comment thread capio/common/requests.hpp Outdated
Comment thread capio/common/requests.hpp Outdated
Comment thread capio/server/include/handlers/close.hpp
Co-authored-by: Iacopo Colonnelli <iacopo.c92@gmail.com>
Copy link
Copy Markdown
Collaborator

@GlassOfWhiskey GlassOfWhiskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GlassOfWhiskey GlassOfWhiskey merged commit 7b58291 into master Mar 5, 2026
40 checks passed
@GlassOfWhiskey GlassOfWhiskey deleted the drop-dead-code branch March 5, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants